Change in osmo-bts[master]: power_control: clarify units in 'struct lchan_power_ctrl_state'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Dec 3 20:03:13 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21500 )

Change subject: power_control: clarify units in 'struct lchan_power_ctrl_state'
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21500/1/include/osmo-bts/gsm_data.h 
File include/osmo-bts/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bts/+/21500/1/include/osmo-bts/gsm_data.h@164 
PS1, Line 164: /* Depending on the context (MS or BS power control), fields 'current' and 'max'
> I still find this a bit strange. […]
Because it makes no sense to use MS power levels (magic numbers from the specs) in context of Downlink power reduction. And vice versa, dB[m] is not useful in the other direction because the MS expects from us / gives us magic numbers.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21500
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I934f2d1e1064eed7587bc5693ef981bf449a1b81
Gerrit-Change-Number: 21500
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Dec 2020 20:03:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/718654da/attachment.htm>


More information about the gerrit-log mailing list