Change in osmo-sgsn[master]: gbproxy: Add BVC log filters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Thu Dec 3 17:30:08 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21495 )

Change subject: gbproxy: Add BVC log filters
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21495/1/src/gbproxy/gb_proxy_vty.c 
File src/gbproxy/gb_proxy_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21495/1/src/gbproxy/gb_proxy_vty.c@556 
PS1, Line 556:       "logging filter bvc bvci <2-65535>",
I'd like some comments on this. Omitting bvci 0 and 1 is not really nice (and in libosmocore filtering on those is allowed) but the other thing I can think of is to set the highest bit in the uintptr_t to 1 if we set a bvci and change the set_log_context to also include that bit.

The gprl_log_filter_fn() in libosmocore only compares whether these pointers are equal.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21495
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4d1b57b89990945d307f27a58a7f630be0253d5b
Gerrit-Change-Number: 21495
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 03 Dec 2020 17:30:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/d005fa21/attachment.htm>


More information about the gerrit-log mailing list