This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21441 ) Change subject: power_control: generalize power control state structure ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21441/1/include/osmo-bts/gsm_data.h File include/osmo-bts/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bts/+/21441/1/include/osmo-bts/gsm_data.h@165 PS1, Line 165: uint8_t current; : uint8_t max; : bool fixed; > If units are different then meaning is different, because the variable contains something else. […] I am not going to spend time on this, sorry. To me it's perfectly fine: we store the 'current' and 'maximum' attenuation / power level depending on the context. It's still 'current' and 'maximum' in both contexts, and still directly related to the power control. I would agree if 'maximum' was abused as 'minimum', but here... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c6ad8d14349e8a05084c2912644c5202f951f52 Gerrit-Change-Number: 21441 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 03 Dec 2020 13:50:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/85db7780/attachment.htm>