This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21474 ) Change subject: gb_proxy: Slightly restructure processing of BSS-originated BVC-RESET ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/21474/1/src/gbproxy/gb_proxy.c File src/gbproxy/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21474/1/src/gbproxy/gb_proxy.c@1020 PS1, Line 1020: return 0; Shouldn't we do the same as goto err_mand_ie in gbprox_rx_sig_from_bss() here? https://gerrit.osmocom.org/c/osmo-sgsn/+/21474/1/src/gbproxy/gb_proxy.c@1022 PS1, Line 1022: bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI)); Not sure if this belongs here or in another patch, but the CELL_ID is also mandatory if bvci identifies a ptp-bvc since this function is only called in BSS->SGSN direction. See 3GPP 48.018 Ch.10.4.12 note 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I038576b91ae1ece149149d8663de7b8495d24e06 Gerrit-Change-Number: 21474 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Comment-Date: Thu, 03 Dec 2020 12:12:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201203/32083d3f/attachment.htm>