Change in osmo-sgsn[master]: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21477 )


Change subject: gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs
......................................................................

gbproxy: Send BVC-STATUS if BSS sends us BVC-RESET without mandatory IEs

Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
---
M src/gbproxy/gb_proxy.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/77/21477/1

diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 2c63614..109a539 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1017,8 +1017,10 @@
 	uint16_t bvci;
 	uint8_t cause;
 
-	if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI) || !TLVP_PRESENT(tp, BSSGP_IE_CAUSE))
-		return 0;
+	if (!TLVP_PRESENT(tp, BSSGP_IE_BVCI) || !TLVP_PRESENT(tp, BSSGP_IE_CAUSE)) {
+		rate_ctr_inc(&cfg->ctrg->ctr[GBPROX_GLOB_CTR_PROTO_ERR_BSS]);
+		return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
+	}
 
 	bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));
 	cause = *TLVP_VAL(tp, BSSGP_IE_CAUSE);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21477
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I198ca70f5e0947735f76d32cd9d3eed159349a94
Gerrit-Change-Number: 21477
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/07689268/attachment.htm>