Change in osmo-sgsn[master]: gb_proxy: Broadcast SGSN-INVOKE-TRACE and OVERLOAD

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21469 )

Change subject: gb_proxy: Broadcast SGSN-INVOKE-TRACE and OVERLOAD
......................................................................

gb_proxy: Broadcast SGSN-INVOKE-TRACE and OVERLOAD

Both BSSGP messages appear from the SGSN in downlink on BVCI=0.

We must send a copy of this message to each of the BSS side NSEs.

Change-Id: Ia19791b143989eb1490f461d88b9edbd8e3b82be
Closes: OS#4875
---
M src/gbproxy/gb_proxy.c
1 file changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 0d79ff7..c5abeb9 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -1290,6 +1290,7 @@
 	struct tlv_parsed tp;
 	uint8_t pdu_type = bgph->pdu_type;
 	int data_len;
+	struct gbproxy_nse *nse;
 	struct gbproxy_peer *peer;
 	uint16_t bvci;
 	struct msgb *msg;
@@ -1401,11 +1402,13 @@
 		rc = gbprox_relay2bvci(cfg, msg, bvci, ns_bvci);
 		break;
 	case BSSGP_PDUT_SGSN_INVOKE_TRACE:
-		LOGP(DGPRS, LOGL_ERROR,
-		     "NSE(%05u/SGSN) BSSGP INVOKE TRACE not supported\n", nsei);
-		rate_ctr_inc(&cfg->ctrg->
-			     ctr[GBPROX_GLOB_CTR_NOT_SUPPORTED_SGSN]);
-		rc = bssgp_tx_status(BSSGP_CAUSE_PDU_INCOMP_FEAT, NULL, orig_msg);
+	case BSSGP_PDUT_OVERLOAD:
+		LOGP(DGPRS, LOGL_DEBUG,
+			"NSE(%05u/SGSN) BSSGP %s: broadcasting\n", nsei, bssgp_pdu_str(pdu_type));
+		/* broadcast to all BSS-side peers */
+		llist_for_each_entry(nse, &cfg->nse_peers, list) {
+			gbprox_relay2nse(msg, nse, 0);
+		}
 		break;
 	default:
 		LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u/SGSN) BSSGP PDU type %s not supported\n", nsei,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21469
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia19791b143989eb1490f461d88b9edbd8e3b82be
Gerrit-Change-Number: 21469
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/23fd1ef8/attachment.htm>