Change in osmo-sgsn[master]: gbproxy: Add todos encountered while going through the code

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21462 )

Change subject: gbproxy: Add todos encountered while going through the code
......................................................................

gbproxy: Add todos encountered while going through the code

Change-Id: I8c3a788f008d3cb2d067d974c2b1b9ca45185d8d
---
M src/gbproxy/gb_proxy.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index 2c58e80..0d79ff7 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -936,6 +936,7 @@
 				       &ns_bvci, msg);
 	}
 
+	/* TODO: Should we discard this message if the check fails */
 	check_peer_nsei(peer, nsei);
 
 	rc = gbprox_process_bssgp_ul(cfg, msg, peer);
@@ -1390,7 +1391,7 @@
 			LOGP(DGPRS, LOGL_NOTICE, "NSE(%05u/SGSN) BSSGP "
 			     "%sBLOCK_ACK for signalling BVCI ?!?\n", nsei,
 			     pdu_type == BSSGP_PDUT_BVC_UNBLOCK_ACK ? "UN":"");
-			/* should we send STATUS ? */
+			/* TODO: should we send STATUS ? */
 			rate_ctr_inc(&cfg->ctrg->
 				     ctr[GBPROX_GLOB_CTR_INV_BVCI]);
 		} else {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21462
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I8c3a788f008d3cb2d067d974c2b1b9ca45185d8d
Gerrit-Change-Number: 21462
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/054d6186/attachment.htm>