Change in libosmocore[master]: Integrate libmnl (minimal netlink) library with libosmocore select loop

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Dec 2 20:45:50 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21457 )

Change subject: Integrate libmnl (minimal netlink) library with libosmocore select loop
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21457/3/include/osmocom/core/mnl.h 
File include/osmocom/core/mnl.h:

https://gerrit.osmocom.org/c/libosmocore/+/21457/3/include/osmocom/core/mnl.h@16 
PS3, Line 16: 	mnl_cb_t mnl_cb;
> What about using something osmocom specific here so we don't depent on libmnl in the public API? It  […]
The problem is that the user (i.e. the implementation of the callback) will need to parse the mnl specific data type arriving there anyway.

So this current patch here is really very netlink specific, and I don't see anything wrong with depending on libmnl.  It is the smallest netlink library out there, it exists for more than a decade, and as it is a dependency of netfilter/iptables tools, it has been packaged basically everywhere.

Supporting other netlink libraries (like libnl) doesn't seem to make sense  to me.  And supporting other operating systems is impossible as they don't have netlink to begin with.   And this entire osmo_mnl module is really just a very thin wrapper on top of netlink, i.e. nothing that you could ever do on a non-netlink-capable system at all.  It has no specific use case whatsoever.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21457
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4f787ee68f0d6d04f0a5655eb57d55b3b326a42f
Gerrit-Change-Number: 21457
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Dec 2020 20:45:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/7cfefee4/attachment.htm>


More information about the gerrit-log mailing list