Change in osmo-sgsn[master]: gbproxy: Use LOG macros for NSE/BVC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Wed Dec 2 16:48:13 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21456 )

Change subject: gbproxy: Use LOG macros for NSE/BVC
......................................................................


Patch Set 4:

(14 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c 
File src/gbproxy/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a462 
PS3, Line 462: 				     "NSEI=%d(BSS) IMSI acquisition was in progress "
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a468 
PS3, Line 468: 				     "NSEI=%d(BSS) IMSI not yet acquired, "
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a487 
PS3, Line 487: 		     "NSEI=%d(BSS) IMSI acquisition succeeded, "
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a516 
PS3, Line 516: 			     "NSEI=%d(BSS) Dropping stored msgb from list "
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a526 
PS3, Line 526: 	     "NSEI=%d(BSS) IMSI acquisition in progress, "
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a537 
PS3, Line 537: 		     "NSEI=%d(BSS) IMSI is required but not available, "
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a607 
PS3, Line 607: 		     "NSEI=%u(BSS) patching: failed to parse invalid %s message\n",
> NSEI can now go?
peer can actually be NULL here, I'll revert and just adjust the formatting


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a724 
PS3, Line 724: 		     "NSEI=%u(SGSN) patching: failed to parse invalid %s message\n",
> NSEI can now go?
peer can actually be NULL here, I'll revert and just adjust the formatting


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a728 
PS3, Line 728: 		     "NSEI=%u(SGSN) invalid message was: %s\n",
> NSEI can now go?
Same


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a990 
PS3, Line 990: 		     "blocked BVCI=%u via NSEI=%u\n",
> Both NSEI and BVCI can go?
The nsei here is the one from the SGSN, so should stay


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@a1063 
PS3, Line 1063: 			"RAI snooping: RAI %s behind BVCI=%u\n",
> BVCI can go?
Ack


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@91 
PS3, Line 91: expected NSEI=%u
> expected that part can go as it's now logged by the macro, right?
The BVCI as well, yeah.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@455 
PS3, Line 455: "NSEI=%d(
> NSEI can now go?
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/21456/3/src/gbproxy/gb_proxy.c@612 
PS3, Line 612: 		LOGPBVC(peer, LOGL_NOTICE,
> NSEI can now go?
Same



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: If445f18bc8390c338b5aeb9085951ea392e68b3a
Gerrit-Change-Number: 21456
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Dec 2020 16:48:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/2e60fdd2/attachment.htm>


More information about the gerrit-log mailing list