This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 ) Change subject: Introduce Android UEs as new modems ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Mostly fine, let's simply try to address the couple issues I pointed out, specially the iperf3 ssh_port thing. I'm open to merge as it is but I'd like to find a better solution if possible. So waiting for your feedback, feel free to reach me by email or jabber if you want. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/4/src/osmo_gsm_tester/obj/android_host.py File src/osmo_gsm_tester/obj/android_host.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/4/src/osmo_gsm_tester/obj/android_host.py@69 PS4, Line 69: # to execute commands on the machine that hosts the Android UE. This function complements with "hosts" you mean "is attached to" right? by means of USB adb? https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/4/src/osmo_gsm_tester/obj/iperf3.py File src/osmo_gsm_tester/obj/iperf3.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/4/src/osmo_gsm_tester/obj/iperf3.py@349 PS4, Line 349: if self._run_node.adb_serial_id() or self._run_node.ssh_port(): we should really find some way to differentiate between run_nodes containing ssh_port and which are still not AndroidUE. For instance, a run_node to a regular host which runs ssh on port != 22. Can you give that another try? Feel free to describe to me the exact problem/scenarios you face somewhere. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/4/src/osmo_gsm_tester/obj/qc_diag.py File src/osmo_gsm_tester/obj/qc_diag.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/4/src/osmo_gsm_tester/obj/qc_diag.py@79 PS4, Line 79: MainLoop.wait(self.finished_parsing, timeout=300) You can pass timestemp=2 if you want to keep the sleep(2) behavior, up to you. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I79a5d803e869a868d4dac5e0d4c2feb38038dc5c Gerrit-Change-Number: 21302 Gerrit-PatchSet: 4 Gerrit-Owner: ninjab3s <nils.fuerste at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 02 Dec 2020 15:59:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/4ac66c97/attachment.htm>