Change in osmo-bts[master]: power_control: derive calc_delta() from lchan_ms_pwr_ctrl()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Dec 2 14:07:36 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21446 )

Change subject: power_control: derive calc_delta() from lchan_ms_pwr_ctrl()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/21446/1/src/common/power_control.c 
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21446/1/src/common/power_control.c@120 
PS1, Line 120: #
> agree with laforge
Ack


https://gerrit.osmocom.org/c/osmo-bts/+/21446/1/src/common/power_control.c@205 
PS1, Line 205: 			  ul_rssi_dbm, params->target);
> This also looks non-related to this patch, or at least may deserve a separate patch.
It's actually a side effect of this patch that this logging statement loses access to the averaged value. On the other hand, printing the average value as 'rx-current' is confusing, because this is not the actual RxLev. I'll separate it too then.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21446
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I2525eb2c3f1fdb3d0847a8ad50b30a44d7741a55
Gerrit-Change-Number: 21446
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Dec 2020 14:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/5333137b/attachment.htm>


More information about the gerrit-log mailing list