Change in osmo-bts[master]: bts: add Downlink power control parameters

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21437 )

Change subject: bts: add Downlink power control parameters
......................................................................

bts: add Downlink power control parameters

Change-Id: I724f661e9ce5dd75f95fb7b270a89b2e2a73c951
Related: SYS#4918
---
M include/osmo-bts/bts.h
M src/common/bts.c
M tests/power/power_test.c
3 files changed, 17 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h
index 129764e..3847a26 100644
--- a/include/osmo-bts/bts.h
+++ b/include/osmo-bts/bts.h
@@ -317,8 +317,9 @@
 		bool vty_override;	/* OML value overridden by VTY */
 	} radio_link_timeout;
 
-	/* Uplink power control */
+	/* Uplink/Downlink power control */
 	struct bts_power_ctrl_params ul_power_ctrl;
+	struct bts_power_ctrl_params dl_power_ctrl;
 
 	/* used by the sysmoBTS to adjust band */
 	uint8_t auto_band;
diff --git a/src/common/bts.c b/src/common/bts.c
index 80f4fdd..a974b9f 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -323,16 +323,26 @@
 
 	/* configurable via VTY */
 	bts->paging_state = paging_init(bts, 200, 0);
-	bts->ul_power_ctrl.target = -75;	/* dBm default */
-	bts->ul_power_ctrl.hysteresis = 3;	/* -78 .. -72 dBm */
-	bts->ul_power_ctrl.pf_algo = BTS_PF_ALGO_EWMA;
-	bts->ul_power_ctrl.pf.ewma.alpha = 50; /* 50% smoothing */
 	bts->rtp_jitter_adaptive = false;
 	bts->rtp_port_range_start = 16384;
 	bts->rtp_port_range_end = 17407;
 	bts->rtp_port_range_next = bts->rtp_port_range_start;
 	bts->rtp_ip_dscp = -1;
 
+	/* Default UL/DL power control parameters */
+	bts->ul_power_ctrl = bts->dl_power_ctrl = \
+	(struct bts_power_ctrl_params) {
+		.target = -75,		/* dBm default */
+		.hysteresis = 3,	/* -78 .. -72 dBm */
+		.pf_algo = BTS_PF_ALGO_EWMA,
+		.pf = {
+			.ewma = {
+				/* 50% smoothing */
+				.alpha = 50
+			}
+		}
+	};
+
 	/* configurable via OML */
 	bts->load.ccch.load_ind_period = 112;
 	load_timer_start(bts);
diff --git a/tests/power/power_test.c b/tests/power/power_test.c
index 14bef08..f1b910b 100644
--- a/tests/power/power_test.c
+++ b/tests/power/power_test.c
@@ -48,6 +48,7 @@
 	g_trx->ms_pwr_ctl_soft = true;
 
 	g_bts->ul_power_ctrl.target = -75;
+	g_bts->dl_power_ctrl.target = -75;
 	g_bts->band = GSM_BAND_1800;
 	g_bts->c0 = g_trx;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21437
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I724f661e9ce5dd75f95fb7b270a89b2e2a73c951
Gerrit-Change-Number: 21437
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/240787bd/attachment.htm>