Change in osmo-bts[master]: bts: generalize a struct for UL/DL power control parameters

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21436 )

Change subject: bts: generalize a struct for UL/DL power control parameters
......................................................................

bts: generalize a struct for UL/DL power control parameters

Change-Id: I504de17fb3c1300c2a3faa6d7d3a9eb1b74b214b
Related: SYS#4918
---
M include/osmo-bts/bts.h
1 file changed, 19 insertions(+), 16 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h
index 37d4c7d..129764e 100644
--- a/include/osmo-bts/bts.h
+++ b/include/osmo-bts/bts.h
@@ -101,6 +101,24 @@
 	BTS_PF_ALGO_EWMA,
 };
 
+/* UL/DL power control parameters */
+struct bts_power_ctrl_params {
+	/* Target value to strive to */
+	int target;
+	/* Tolerated deviation from target */
+	int hysteresis;
+	/* RxLev filtering algorithm */
+	enum bts_pf_algo pf_algo;
+	/* (Optional) filtering parameters */
+	union {
+		/* Exponentially Weighted Moving Average */
+		struct {
+			/* Smoothing factor: higher the value - less smoothing */
+			uint8_t alpha; /* 1 .. 99 (in %) */
+		} ewma;
+	} pf;
+};
+
 /* BTS Site Manager */
 struct gsm_bts_sm {
 	struct gsm_abis_mo mo;
@@ -300,22 +318,7 @@
 	} radio_link_timeout;
 
 	/* Uplink power control */
-	struct {
-		/* Target value to strive to */
-		int target;
-		/* Tolerated deviation from target */
-		int hysteresis;
-		/* UL RSSI filtering algorithm */
-		enum bts_pf_algo pf_algo;
-		/* (Optional) filtering parameters */
-		union {
-			/* Exponentially Weighted Moving Average */
-			struct {
-				/* Smoothing factor: higher the value - less smoothing */
-				uint8_t alpha; /* 1 .. 99 (in %) */
-			} ewma;
-		} pf;
-	} ul_power_ctrl;
+	struct bts_power_ctrl_params ul_power_ctrl;
 
 	/* used by the sysmoBTS to adjust band */
 	uint8_t auto_band;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21436
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I504de17fb3c1300c2a3faa6d7d3a9eb1b74b214b
Gerrit-Change-Number: 21436
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201202/d09161a2/attachment.htm>