Change in osmo-bts[master]: vty: fix dump_lchan_trx_ts(): dump dedicated channels only

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/21450 )


Change subject: vty: fix dump_lchan_trx_ts(): dump dedicated channels only
......................................................................

vty: fix dump_lchan_trx_ts(): dump dedicated channels only

It does not make sense to dump CCCH/CBCH as dedicated channels:

  OsmoBTS# show lchan
  BTS 0, TRX 0, Timeslot 0, Lchan 4: Type CCCH
    State: ACTIVE
    BS (Downlink) Power Control (autonomous):
      Channel reduction: 0 dB (max 0 dB)
      TRX reduction: 0 dB
      Actual / Nominal power: 13 dBm / 13 dBm
    MS (Uplink) Power Control (autonomous):
      Current power level: 0, -39 dBm (max 0, -39 dBm)
    Channel Mode / Codec: SIGNALLING
    LAPDm SAPIs: DCCH --, SACCH --
    Valid System Information: 0x00000060
    MS Timing Offset: 0, propagation delay: 0 symbols
    Radio Link Failure Counter 'S': 0

so let's only dump SDCCH, TCH/F, and TCH/H.

Change-Id: Id7880de56a93cc9fa4ca576b094cef35ee269822
---
M src/common/vty.c
1 file changed, 8 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/21450/1

diff --git a/src/common/vty.c b/src/common/vty.c
index 7baddef..8837079 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -1405,9 +1405,15 @@
 	int lchan_nr;
 	for (lchan_nr = 0; lchan_nr < TS_MAX_LCHAN; lchan_nr++) {
 		const struct gsm_lchan *lchan = &ts->lchan[lchan_nr];
-		if (lchan->state == LCHAN_S_NONE)
+		switch (lchan->state) {
+		case GSM_LCHAN_SDCCH:
+		case GSM_LCHAN_TCH_F:
+		case GSM_LCHAN_TCH_H:
+			dump_cb(vty, lchan);
+			break;
+		default:
 			continue;
-		dump_cb(vty, lchan);
+		}
 	}
 
 	return CMD_SUCCESS;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21450
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id7880de56a93cc9fa4ca576b094cef35ee269822
Gerrit-Change-Number: 21450
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/05922eaf/attachment.htm>