Change in osmo-bsc[master]: ctrl_test_runner.py: remove per-test startup delay

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 1 12:09:26 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21207 )

Change subject: ctrl_test_runner.py: remove per-test startup delay
......................................................................

ctrl_test_runner.py: remove per-test startup delay

The CTRL connect already includes 30 retries with .1 seconds delay each, so
there is no point in adding a fixed two second delay that unnecessarily drags
out test duration for each test.

Change-Id: I830fabbd037d6e945956a99aa3f5e4d4015ea165
---
M tests/ctrl_test_runner.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py
index e1c11b9..5d2af85 100755
--- a/tests/ctrl_test_runner.py
+++ b/tests/ctrl_test_runner.py
@@ -55,7 +55,6 @@
         except OSError:
             print("Current directory: %s" % os.getcwd(), file=sys.stderr)
             print("Consider setting -b", file=sys.stderr)
-        time.sleep(2)
 
         appstring = self.ctrl_app()[2]
         appport = self.ctrl_app()[0]

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I830fabbd037d6e945956a99aa3f5e4d4015ea165
Gerrit-Change-Number: 21207
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/635fbafb/attachment.htm>


More information about the gerrit-log mailing list