Change in osmo-bts[master]: l1sap: also include SRR bit in RSL l1 info field.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Dec 1 12:01:30 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21088 )

Change subject: l1sap: also include SRR bit in RSL l1 info field.
......................................................................

l1sap: also include SRR bit in RSL l1 info field.

The SRR bit, which got specified in 3gpp release 6 to support repeated
ACCH capability is not yet included in the L1 Information IE on RSL
level. Also lets update the spec reference to more modern 3gpp spec ref
numbers.

Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6
Related: OS#4796 SYS#5114
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 4398f2a..3c45b62 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1463,10 +1463,11 @@
 		}
 		/* Some brilliant engineer decided that the ordering of
 		 * fields on the Um interface is different from the
-		 * order of fields in RSL. See TS 04.04 (Chapter 7.2)
-		 * vs. TS 08.58 (Chapter 9.3.10). */
+		 * order of fields in RSL. See 3GPP TS 44.004 (section 7.2)
+		 * vs. 3GPP TS 48.058 (section 9.3.10). */
 		lchan->meas.l1_info[0] = data[0] << 3;
-		lchan->meas.l1_info[0] |= ((data[0] >> 5) & 1) << 2;
+		lchan->meas.l1_info[0] |= ((data[0] >> 5) & 1) << 2; /* FPC/EPC */
+		lchan->meas.l1_info[0] |= ((data[0] >> 6) & 1) << 1; /* SRR */
 		lchan->meas.l1_info[1] = data[1];
 		lchan->meas.flags |= LC_UL_M_F_L1_VALID;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21088
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I987c61608b737521ba36756dabf2f6215b34c2d6
Gerrit-Change-Number: 21088
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/66f5d07d/attachment.htm>


More information about the gerrit-log mailing list