Change in osmo-pcu[master]: Dl TBF: Get rid of LLC UI dummy blocks following other data

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Dec 1 11:56:00 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21387 )

Change subject: Dl TBF: Get rid of LLC UI dummy blocks following other data
......................................................................


Patch Set 4:

> Patch Set 4: Code-Review+1
> 
> did you confirm this by looking at 'public operator' GPRS downlink blocks?

No, what would you suggest to get those?
In any case, I think the specs are quite clear IMHO. I think it was done this way beforehand because it was easier from code implementation point of view at the PCU, and it's not "strictly" or "explicitly" wrong anyway since MS should be discarding those. Still, that means extra processing at MS side as well as making traces more complex to follow.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f
Gerrit-Change-Number: 21387
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Tue, 01 Dec 2020 11:56:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201201/25cc18a1/attachment.htm>


More information about the gerrit-log mailing list