Change in osmo-trx[master]: Add support for TRXC MUTE command

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19828 )

Change subject: Add support for TRXC MUTE command
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-trx/+/19828/2/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/19828/2/Transceiver52M/Transceiver.cpp@1014 
PS2, Line 1014: } else if (match_cmd(command, "RFMUTE", &params)) {
Something is wrong with spacing here.


https://gerrit.osmocom.org/c/osmo-trx/+/19828/2/Transceiver52M/Transceiver.cpp@1015 
PS2, Line 1015: set TRXD protocol version
copy pasted?


https://gerrit.osmocom.org/c/osmo-trx/+/19828/2/Transceiver52M/Transceiver.cpp@1018 
PS2, Line 1018:      mStates[chan].mMuted = mute ? true : false;
... and here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19828
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I39983d026ad54c479aa224968e9491d01f30dc35
Gerrit-Change-Number: 19828
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Mon, 31 Aug 2020 18:41:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200831/9ca261f0/attachment.htm>