Change in libosmocore[master]: socket: Add some osmo_sockaddr print helpers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Aug 31 18:22:16 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19917 )

Change subject: socket: Add some osmo_sockaddr print helpers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/19917/1/src/socket.c 
File src/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/19917/1/src/socket.c@1010 
PS1, Line 1010: const struct sockaddr *sa, char *dst
> How about the opposite order of arguments, like in memcpy()/memset()?
Go tell the guy who wrote inet_ntop in first place, I'm simply mimicing it:
       const char *inet_ntop(int af, const void *src,
                             char *dst, socklen_t size);



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19917
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie07a38b05b7888885dba4ae795e9f3d9a561543d
Gerrit-Change-Number: 19917
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Aug 2020 18:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200831/dc5369e4/attachment.htm>


More information about the gerrit-log mailing list