Change in osmo-ttcn3-hacks[master]: library/Osmocom_Types: fix: '10111111'B is a valid emergency RA

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19905 )

Change subject: library/Osmocom_Types: fix: '10111111'B is a valid emergency RA
......................................................................

library/Osmocom_Types: fix: '10111111'B is a valid emergency RA

Most likely, the second part of the condition was copy-pasted
from ra_is_ps(), where the specs. require that at least one
of the three LSB's shall be zero.  This requirement does not
apply to emergency RA values in range '101xxxxx'B.

Change-Id: I4c923682edfeee9c6bf3aeeeb67438809a54109f
---
M library/Osmocom_Types.ttcn
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn
index 2ee3215..fa36881 100644
--- a/library/Osmocom_Types.ttcn
+++ b/library/Osmocom_Types.ttcn
@@ -208,10 +208,7 @@
 
 function ra_is_emerg(OCT1 ra) return boolean {
 	/* See also: 3GPP TS 04.08, Table 9.9, ra=101xxxxx */
-	if ((ra and4b 'E0'O == 'A0'O) and (ra and4b '1F'O != '1F'O)) {
-		return true;
-	}
-	return false;
+	return (ra and4b 'E0'O == 'A0'O);
 }
 
 /* generate a random RACH for circuit-switched */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19905
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4c923682edfeee9c6bf3aeeeb67438809a54109f
Gerrit-Change-Number: 19905
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200831/a979e1c9/attachment.htm>