Change in osmo-bsc[master]: abis_rsl: fix IAR Rest Octets in rsl_send_imm_ass_rej()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19890 )


Change subject: abis_rsl: fix IAR Rest Octets in rsl_send_imm_ass_rej()
......................................................................

abis_rsl: fix IAR Rest Octets in rsl_send_imm_ass_rej()

Currently osmo-bsc encodes the IAR Rest Octets as follows:

  IAR Rest Octets
    0... .... = Extended RA: Not Present
    .0.. .... = Extended RA: Not Present
    ..1. .... = Extended RA: Present
    ...0 1011 = Extended_RA: 11
    0... .... = Extended RA: Not Present
    .L.. .... = Additions in Rel-13: Not Present
    Padding Bits: default padding

This is not really critical, but still may look confusing as this
is only relevant for the PS domain (11-bit RA), while osmo-bsc is
responding to a CHANNEL REQUEST in the CS domain.

Change-Id: I30a43efc70345a4bb0571127c239a24422b7fd2c
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/19890/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 6787511..d3f7de2 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -1305,7 +1305,15 @@
 	/* we need to subtract 1 byte from sizeof(*iar) since ia includes the l2_plen field */
 	iar->l2_plen = GSM48_LEN2PLEN((sizeof(*iar)-1));
 
-	return rsl_imm_assign_cmd(bts, sizeof(*iar), (uint8_t *) iar);
+	/* IAR Rest Octets:
+	 *   0... .... = Extended RA: Not Present
+	 *   .0.. .... = Extended RA: Not Present
+	 *   ..0. .... = Extended RA: Not Present
+	 *   ...0 .... = Extended RA: Not Present
+	 *   .... L... = Additions in Rel-13: Not Present */
+	iar->rest[0] = GSM_MACBLOCK_PADDING & 0x0f;
+
+	return rsl_imm_assign_cmd(bts, sizeof(*iar) + 1, buf);
 }
 
 int rsl_tx_imm_ass_rej(struct gsm_bts *bts, struct gsm48_req_ref *rqd_ref)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19890
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I30a43efc70345a4bb0571127c239a24422b7fd2c
Gerrit-Change-Number: 19890
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200829/b314cdc9/attachment.htm>