Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix measurement handling for SUB frames

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri Aug 28 14:31:42 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18035 )

Change subject: osmo-bts-trx/scheduler: fix measurement handling for SUB frames
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

as i pointed out before...

https://gerrit.osmocom.org/c/osmo-bts/+/18035/8/src/osmo-bts-trx/sched_lchan_tchf.c 
File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18035/8/src/osmo-bts-trx/sched_lchan_tchf.c@176 
PS8, Line 176: 		/* FIXME: any spec. references? */
please add the reference or drop this comment, this doesn't help at all and doesn't really qualify for a FIXME either


https://gerrit.osmocom.org/c/osmo-bts/+/18035/8/src/osmo-bts-trx/sched_lchan_tchh.c 
File src/osmo-bts-trx/sched_lchan_tchh.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18035/8/src/osmo-bts-trx/sched_lchan_tchh.c@187 
PS8, Line 187: 		/* FIXME: any spec. references? */
please add the reference or drop this comment, this doesn't help at all and doesn't really qualify for a FIXME either



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18035
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I902bb47d68742d2589156f61099b67a0edbaf40b
Gerrit-Change-Number: 18035
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Aug 2020 14:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200828/bddf70b2/attachment.htm>


More information about the gerrit-log mailing list