Change in osmo-gsm-tester[master]: ms_srs: trim leading zeros in UE metrics when calculating min_rolling...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Fri Aug 28 08:58:04 UTC 2020


srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19862 )


Change subject: ms_srs: trim leading zeros in UE metrics when calculating min_rolling_avg
......................................................................

ms_srs: trim leading zeros in UE metrics when calculating min_rolling_avg

this avoids a false negative detection when the UE attach takes a bit
longer and the first seconds all zeros are reported in the CSV

the HO test, for example, would fail in such a case as it expects
no zero TP over the course of the experiment.

Change-Id: I96dab17bb19249504dedda6659aed5eac0a65a26
---
M src/osmo_gsm_tester/obj/ms_srs.py
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/62/19862/1

diff --git a/src/osmo_gsm_tester/obj/ms_srs.py b/src/osmo_gsm_tester/obj/ms_srs.py
index 124b113..1c0f728 100644
--- a/src/osmo_gsm_tester/obj/ms_srs.py
+++ b/src/osmo_gsm_tester/obj/ms_srs.py
@@ -460,6 +460,8 @@
             # calculate rolling average over window and take maximum value
             result = numpy.amax(numpy.convolve(sel_data, numpy.ones((window,))/window, mode='valid'))
         elif operation == 'min_rolling_avg':
+            # trim leading zeros to avoid false negative when UE attach takes longer
+            sel_data = numpy.trim_zeros(sel_data, 'f')
             # calculate rolling average over window and take minimum value
             result = numpy.amin(numpy.convolve(sel_data, numpy.ones((window,))/window, mode='valid'))
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/19862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I96dab17bb19249504dedda6659aed5eac0a65a26
Gerrit-Change-Number: 19862
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200828/55973504/attachment.htm>


More information about the gerrit-log mailing list