This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/19851 ) Change subject: Validate correctly against IPv6 addresses in osmo_ss7_asp_peer_set_hosts() ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1//COMMIT_MSG@8 PS1, Line 8: should explain what needed to be corrected... https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1/src/osmo_ss7.c@1140 PS1, Line 1140: static inline bool host_is_ipv6(const char *host) we already have osmo_ip_str_type() in libosmocore/include/osmocom/core/sockaddr_str.h https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1/src/osmo_ss7.c@1152 PS1, Line 1152: /* Expects an IPv6 address formatted string (no NULL) */ interesting, so NULL is v4 ANY, while :: is v6 ANY? That may be applied to osmo_ip_str_type() if it is generic enough? (i.e. osmo_ip_str_type() returns AF_UNSPEC for NULL, maybe it should return AF_INET instead?) Alternatively this code here could use something like host = host ? : "0.0.0.0"; also thinking that maybe some osmo_ip_str_is_any() could be added to sockaddr_str.h https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1/src/osmo_ss7.c@1168 PS1, Line 1168: bool new_is_any = host_is_ipv4_anyaddr(host) || host_is_ipv6_anyaddr(host); looks like a host_is_any() for both v4 and v6 would be less code https://gerrit.osmocom.org/c/libosmo-sccp/+/19851/1/src/osmo_ss7.c@1191 PS1, Line 1191: : host_is_ipv4_anyaddr(peer->host[i]); (since v4/v6 is already checked, a plain host_is_any() mentioned above would also work here) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/19851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I18f3cc59149d478259d7afc456bdc5213c1406e5 Gerrit-Change-Number: 19851 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Thu, 27 Aug 2020 15:02:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200827/db8d1946/attachment.htm>