Change in libosmocore[master]: lapd_test: rename func=UA (RR) CM Service Request: s/ua/ua_cm/

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19845 )

Change subject: lapd_test: rename func=UA (RR) CM Service Request: s/ua/ua_cm/
......................................................................

lapd_test: rename func=UA (RR) CM Service Request: s/ua/ua_cm/

This is basically an ACKnowledgement for (RR) CM Service Request,
thus it contains a copy of the original Uplink message (cm).
Let's rename it to reflect this explicitly.

Change-Id: Id497ff4b688528916495387d64915b14396a68f1
---
M tests/lapd/lapd_test.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/tests/lapd/lapd_test.c b/tests/lapd/lapd_test.c
index 8a15b6d..f1659ef 100644
--- a/tests/lapd/lapd_test.c
+++ b/tests/lapd/lapd_test.c
@@ -67,7 +67,7 @@
 	0x29, 0x47, 0x80, 0x00, 0x00, 0x00, 0x00, 0x80,
 };
 
-static const uint8_t ua[] = {
+static const uint8_t ua_cm[] = {
 	0x01, 0x73, 0x41, 0x05, 0x24, 0x31, 0x03, 0x50,
 	0x18, 0x93, 0x08, 0x29, 0x47, 0x80, 0x00, 0x00,
 	0x00, 0x00, 0x80, 0x2b, 0x2b, 0x2b, 0x2b
@@ -491,7 +491,7 @@
 	send_sabm(&bts_to_ms_channel, 0, cm, sizeof(cm));
 	rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH");
 	CHECK_RC(rc);
-	OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0);
+	OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_cm, ARRAY_SIZE(ua_cm)) == 0);
 	msgb_free(pp.oph.msg);
 
 	/* Send SABM MS 2, we must get nothing, due to collision */
@@ -507,7 +507,7 @@
 	send_sabm(&bts_to_ms_channel, 0, cm, sizeof(cm));
 	rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH");
 	CHECK_RC(rc);
-	OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0);
+	OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_cm, ARRAY_SIZE(ua_cm)) == 0);
 	msgb_free(pp.oph.msg);
 
 	/* clean up */
@@ -698,7 +698,7 @@
 
 	rc = dequeue_prim(&bts_to_ms_channel.lapdm_dcch, &pp, "DCCH");
 	CHECK_RC(rc);
-	OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua, ARRAY_SIZE(ua)) == 0);
+	OSMO_ASSERT(memcmp(pp.oph.msg->l2h, ua_cm, ARRAY_SIZE(ua_cm)) == 0);
 	msgb_free(pp.oph.msg);
 
 	printf("\nSending Classmark Change\n");

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19845
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id497ff4b688528916495387d64915b14396a68f1
Gerrit-Change-Number: 19845
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200827/83b4e201/attachment.htm>