Change in osmo-bsc[master]: bsc_subscr_conn_fsm: fix a memleak in rll_ind_cb()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Aug 26 19:06:00 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19825 )

Change subject: bsc_subscr_conn_fsm: fix a memleak in rll_ind_cb()
......................................................................

bsc_subscr_conn_fsm: fix a memleak in rll_ind_cb()

Change-Id: I9ce35c1e446b0dfdb5b01651466ccaafc23c9318
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 22aa70a..4f559fe 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -1026,8 +1026,10 @@
 	 * fire after a lchan_release call and before the S_CHALLOC_FREED
 	 * is called. Check if a conn is set before proceeding.
 	 */
-	if (!lchan->conn)
+	if (!lchan->conn) {
+		msgb_free(msg);
 		return;
+	}
 
 	switch (rllr_ind) {
 	case BSC_RLLR_IND_EST_CONF:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19825
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ce35c1e446b0dfdb5b01651466ccaafc23c9318
Gerrit-Change-Number: 19825
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200826/776dc922/attachment.htm>


More information about the gerrit-log mailing list