Change in ...osmo_ss7[master]: ipa_proto: Hook ipa_proto_ccm into the handling of CCM messages

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/19808 )

Change subject: ipa_proto: Hook ipa_proto_ccm into the handling of CCM messages
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/19808/1/src/ipa_proto.erl 
File src/ipa_proto.erl:

https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/19808/1/src/ipa_proto.erl@278 
PS1, Line 278: 	C
this clearly is an ugly hack and we don't want to send this MME string unconditionally.  The user application would have to somehow hae to specify what to send, a library should not contain hard-coded identifiers.  As this is a parameter of the socket, the application would have to somehow tell the library about it. I think we need a new function analogous to controlling_process(Socket, StreamID, NewPid), which then would be used to set arbitrary IPA CCM options.

Like set_ccm_options(Socket, CcmOpts) where CcmOpts is a list of tuples like  the one {string,serial_nr, ...} above.



-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/19808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo_ss7
Gerrit-Branch: master
Gerrit-Change-Id: I03c2b12ffbedd38ca0c308a120f2435c2b773b65
Gerrit-Change-Number: 19808
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 25 Aug 2020 07:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200825/9cd69369/attachment.htm>