This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19784 ) Change subject: encoding: fix RRBP field in write_packet_uplink_assignment() ...................................................................... encoding: fix RRBP field in write_packet_uplink_assignment() Do not hard-code 0x00, write what was passed as a parameter. Change-Id: I9eb362292e9f4c16d4b8f8d4253df0422062eeb4 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/encoding.cpp b/src/encoding.cpp index 2025a0f..6a60485 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -548,7 +548,7 @@ uint8_t ta_ts = 0; /* FIXME: supply it as parameter from caller */ bitvec_write_field(dest, &wp,0x1,2); // Payload Type - bitvec_write_field(dest, &wp,0x0,2); // Uplink block with TDMA framenumber (N+13) + bitvec_write_field(dest, &wp,rrbp,2); // Uplink block with TDMA framenumber (N+13) bitvec_write_field(dest, &wp,poll,1); // Suppl/Polling Bit bitvec_write_field(dest, &wp,0x0,3); // Uplink state flag bitvec_write_field(dest, &wp,0xa,6); // MESSAGE TYPE -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9eb362292e9f4c16d4b8f8d4253df0422062eeb4 Gerrit-Change-Number: 19784 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200824/9fa5f046/attachment.htm>