Change in osmo-msc[master]: fix crash for unknown MI during Paging Response

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Aug 24 00:49:57 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19722 )

Change subject: fix crash for unknown MI during Paging Response
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/19722/1/src/libmsc/gsm_04_08.c 
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/c/osmo-msc/+/19722/1/src/libmsc/gsm_04_08.c@1189 
PS1, Line 1189: 		/* Above MSC_A_USE_PAGING_RESPONSE may already have been removed by a forced release, put that use only
> Shouldn't we simply avoid destroying the object during that forced release, to avoid this kind of pr […]
yes, you're right.

We could still merge this as a measure to fix the pretty bad crash without affecting other code first,
and keep OS#4724 open for fixing the forced refcount clear upon release?
I don't recall the reason why I introduced such messed up refcount clearing, it could become complex.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19722
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia2c8fa745cfab17ed7114d433f625ddc02ae7b11
Gerrit-Change-Number: 19722
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Aug 2020 00:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200824/7acf2f45/attachment.htm>


More information about the gerrit-log mailing list