Change in osmo-sgsn[master]: Change default SCTP conn NULL->127.0.0.1 to localhost->localhost

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Aug 20 16:47:16 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/19741 )


Change subject: Change default SCTP conn NULL->127.0.0.1 to localhost->localhost
......................................................................

Change default SCTP conn NULL->127.0.0.1 to localhost->localhost

"127.0.0.1" is changed to "localhost" to let local DNS decide whether to
use IPv4 or IPv6. In newish systems, IPv6 ::1 will be selected since
IPv6 takes precedence over IPv4.

Similarly, the default source addr needs to be changed from NULL to "localhost"
since for some yet unknwon reason, getaddrinfo(AF_UNSPEC, NULL) returns
first IPv4 "0.0.0.0" and later "::", which is inconsistent with
getaddrinfo("localhost") result, resulting in src=IPv4(0.0.0.0) and
dst=IPv6(::1), which is incompatible and will fail. In any case, since
the default remote address is a local one and it's the client side,
there's no real logical change since the kernel would anyway should have
taken a local address anyway.

Change-Id: I2f599e1aa449d44136ef20ba5f516ca9b61f3223
---
M src/sgsn/sgsn_main.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/41/19741/1

diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c
index 257c3a2..3044f95 100644
--- a/src/sgsn/sgsn_main.c
+++ b/src/sgsn/sgsn_main.c
@@ -532,8 +532,8 @@
 						 "OsmoSGSN",
 						 (23 << 3) + 4,
 						 OSMO_SS7_ASP_PROT_M3UA,
-						 0, NULL,
-						 0, "127.0.0.1");
+						 0, "localhost",
+						 0, "localhost");
 	if (!sccp) {
 		printf("Setting up SCCP client failed.\n");
 		return 8;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2f599e1aa449d44136ef20ba5f516ca9b61f3223
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200820/62557735/attachment.htm>


More information about the gerrit-log mailing list