Change in libosmocore[master]: vty/command: cosmetic: swap i and j in vty_dump_element()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19701 )

Change subject: vty/command: cosmetic: swap i and j in vty_dump_element()
......................................................................

vty/command: cosmetic: swap i and j in vty_dump_element()

It's more convenient to use i in the outer loop, and j, k, etc.
in the inner loops.  Otherwise it looks a bit confusing.

Change-Id: I61ef48fcf977d6a872e288571a4ff2c3dfe3184b
---
M src/vty/command.c
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/vty/command.c b/src/vty/command.c
index d5e9d27..722b3e0 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -632,13 +632,13 @@
 	print_func(data, "    <command id='%s'>%s", xml_string, newline);
 	print_func(data, "      <params>%s", newline);
 
-	int j;
-	for (j = 0; j < vector_count(cmd->strvec); ++j) {
-		vector descvec = vector_slot(cmd->strvec, j);
-		int i;
-		for (i = 0; i < vector_active(descvec); ++i) {
+	int i;
+	for (i = 0; i < vector_count(cmd->strvec); ++i) {
+		vector descvec = vector_slot(cmd->strvec, i);
+		int j;
+		for (j = 0; j < vector_active(descvec); ++j) {
 			char *xml_param, *xml_doc;
-			struct desc *desc = vector_slot(descvec, i);
+			struct desc *desc = vector_slot(descvec, j);
 			if (desc == NULL)
 				continue;
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19701
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I61ef48fcf977d6a872e288571a4ff2c3dfe3184b
Gerrit-Change-Number: 19701
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200820/5e93e583/attachment.htm>