Change in osmo-ttcn3-hacks[master]: msc: Make TC_lu_and_mo_call_sccp_tiar_timeout() more reliable

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19715 )

Change subject: msc: Make TC_lu_and_mo_call_sccp_tiar_timeout() more reliable
......................................................................

msc: Make TC_lu_and_mo_call_sccp_tiar_timeout() more reliable

There is a race condition when shutting down, as a DLCX might arrive
while we are half-shutdown.  Expect both DLCX before terminating
the ConnHdlr.

Change-Id: Ia0342a9bb346929e0e538f4cb571abfc4acac6bf
---
M msc/MSC_Tests.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 63e90f4..bdd9f62 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -702,12 +702,15 @@
 				T_wait_iar.stop
 				setverdict(pass);
 		}
-	[] MGCP.receive(tr_DLCX(?)) { repeat; }
 	[] T_wait_iar.timeout {
 		setverdict(fail, "Timeout waiting for T(iar) triggered SCCP RSLD");
 		mtc.stop;
 		}
 	}
+	/* DLCX for both directions; if we don't do this, we might receive either of the two during
+	 * shutdown causing race conditions */
+	MGCP.receive(tr_DLCX(?));
+	MGCP.receive(tr_DLCX(?));
 
 	setverdict(pass);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19715
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0342a9bb346929e0e538f4cb571abfc4acac6bf
Gerrit-Change-Number: 19715
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200820/18c56021/attachment.htm>