This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19706 ) Change subject: Introduce log macro helper LOGPMS ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/19706/1/src/gprs_ms.h File src/gprs_ms.h: https://gerrit.osmocom.org/c/osmo-pcu/+/19706/1/src/gprs_ms.h@302 PS1, Line 302: PRIu8 ", %" PRIu8 "/%" PRIu8 > Why not just '%u'? What's wrong with it? If there's a specific standard format for uint8_t, why not use it? IMHo it's good practice to always use those, because despite in this specific case not needed due to promotion to word size, in others it does make a difference. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib304ced06531a5154b7ec8bf87f9717dfd7d1397 Gerrit-Change-Number: 19706 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 19 Aug 2020 08:55:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200819/2b01f6dd/attachment.htm>