Change in osmo-mgw[master]: mgcp_e1: remove unused struct member trunk->e1.line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Aug 19 07:19:09 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19711 )

Change subject: mgcp_e1: remove unused struct member trunk->e1.line
......................................................................


Patch Set 1:

In general, particularly in the context of efficiency, we should avoid looking up an object (such as the E1 line) again and again at runtime. Is this the case? Please verify.  If we frequently end up calling e1inp_line_find(), we should do the look-up once and cache the result in a member variable, this is typically more efficient.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id4ff52285917ce3885b8dad3a16270999c9da0aa
Gerrit-Change-Number: 19711
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 19 Aug 2020 07:19:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200819/4cdbbb38/attachment.htm>


More information about the gerrit-log mailing list