This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19665 ) Change subject: vty/command: cosmetic: move variable definition upwards ...................................................................... Patch Set 1: > Patch Set 1: > > not really sure this is an improvement. The variables are scope-local now (good) and you move them to the function scope. If you insist, but I'd not really see it as an improvement. I initially thought that I would need both i and j variables, but in the end I used only i. I'll abandon this change. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I491913061799cd0bfaa78d76f88a5c819f1d5e2e Gerrit-Change-Number: 19665 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 18 Aug 2020 09:08:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200818/df225257/attachment.htm>