Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types: version 10: support IPv6 NSVC addr

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19420 )

Change subject: library/PCUIF_Types: version 10: support IPv6 NSVC addr
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19420/5/library/PCUIF_Types.ttcn 
File library/PCUIF_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19420/5/library/PCUIF_Types.ttcn@215 
PS5, Line 215: 	/* NOTE: TITAN is not smart enough to handle 'version < 10' and 'version > 9',
This doesn't seem to hold true with using CROSSTAG, iirc I already pointed that out previously in a prior patch?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19420/5/library/PCUIF_Types.ttcn@231 
PS5, Line 231: 	PCUIF_ADDR_TYPE_UNSPEC		('00'O),
Does it really make sense from protocol point of view to be sending UNSPEC at any time?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I13b03c380edc2dc609c5e4053462a3cd6f78ce72
Gerrit-Change-Number: 19420
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Aug 2020 11:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200817/d764175d/attachment.htm>