Change in osmo-mgw[master]: mgcp_e1: use return value of e1inp_line_update()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Aug 15 07:43:38 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19638 )

Change subject: mgcp_e1: use return value of e1inp_line_update()
......................................................................

mgcp_e1: use return value of e1inp_line_update()

The function e1inp_line_update() is called without assigning its return
code to the rc variable.

Change-Id: Ia72ea2dca210b038766151d547f66b7b7139a2c4
Fixes: CID#212160
---
M src/libosmo-mgcp/mgcp_e1.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c
index 8444b11..b3db0b7 100644
--- a/src/libosmo-mgcp/mgcp_e1.c
+++ b/src/libosmo-mgcp/mgcp_e1.c
@@ -402,7 +402,7 @@
 	rc = e1inp_ts_config_raw(&e1_line->ts[ts_nr - 1], e1_line, e1_recv_cb);
 	if (rc < 0)
 		return -EINVAL;
-	e1inp_line_update(e1_line);
+	rc = e1inp_line_update(e1_line);
 	if (rc < 0)
 		return -EINVAL;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19638
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ia72ea2dca210b038766151d547f66b7b7139a2c4
Gerrit-Change-Number: 19638
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200815/0b00d00f/attachment.htm>


More information about the gerrit-log mailing list