Change in osmo-ttcn3-hacks[master]: bsc CBSP: clear all CBSP state between runs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Aug 13 19:31:23 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19635 )

Change subject: bsc CBSP: clear all CBSP state between runs
......................................................................

bsc CBSP: clear all CBSP state between runs

Some tests may stop without cleaning up the CBSP state. Avoid affecting
subsequent tests by clearing the state for each f_cbsp_init_server().

Some ETWS CMD may still be left in the RSL queue (from the time period passing
between a stopped test and the next test starting up), so clear all RSL ports.

To be able to do so, move f_cbsp_reset_bss() to the cbsp_test_CT, from where it
can access both CBSP and IPA_RSL[] ports. All current callers are on
cbsp_test_CT anyway.

This patch should fix TC_cbsp_emerg_write_bts_cgi_cchan and
TC_cbsp_emerg_write_bts_cgi_cchan_disable, which so far break because of
leftover ETWS CMDs in the RSL queue from the preceding test run.

Change-Id: If7400a6624bb6dd9cacbcc733bdeba102d19e29c
---
M bsc/BSC_Tests_CBSP.ttcn
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn
index 67fbd50..497ff80 100644
--- a/bsc/BSC_Tests_CBSP.ttcn
+++ b/bsc/BSC_Tests_CBSP.ttcn
@@ -139,6 +139,8 @@
 	g_cbsp_msg_id := cbsp_msg_id;
 	g_cbsp_ser_no := cbsp_ser_no;
 	log("g_cbsp_msg_id=", g_cbsp_msg_id, "  g_cbsp_ser_no=", g_cbsp_ser_no);
+
+	f_cbsp_reset_bss(0);
 }
 private function f_expect_cbsp_restart() runs on cbsp_test_CT {
 	interleave {
@@ -161,7 +163,12 @@
 	return valueof(ts_CbspMsgContent(payload, payload_len));
 }
 
-function f_cbsp_reset_bss(integer idx) runs on CBSP_Adapter_CT {
+function f_cbsp_reset_bss(integer idx) runs on cbsp_test_CT {
+	/* Make sure no CBSP ETWS commands from a previous CBSP test remain in the RSL queue */
+	IPA_RSL[0].clear;
+	IPA_RSL[1].clear;
+	IPA_RSL[2].clear;
+
 	var template (value) CBSP_PDU tx;
 	timer T := 3.0;
 	tx := ts_CBSP_RESET(cell_list := ts_BSSMAP_CIL_BSS);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19635
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If7400a6624bb6dd9cacbcc733bdeba102d19e29c
Gerrit-Change-Number: 19635
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200813/bd89d225/attachment.htm>


More information about the gerrit-log mailing list