This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19632 ) Change subject: CBSP: on RESET, also clear the etws_timer, and stop all CBSP broadcast ...................................................................... CBSP: on RESET, also clear the etws_timer, and stop all CBSP broadcast Before this patch, each ETWS CMD instructing to broadcast triggered a five second etws_timer to send a zero-payload ETWS CMD that stops broadcasting, five seconds later. This lingered past an ETWS RESET instruction. Instead, clear the etws_timer on ETWS RESET, and make sure that all broadcast is stopped by sending a zero payload ETWS CMD to the BTSes immediately. This will cause all CBSP ttcn3 tests to fail unless Ifee313369a433a6a638c5fffdedee5363b8e47c2 is merged to osmo-ttcn3-hacks at the same time. Related: Ifee313369a433a6a638c5fffdedee5363b8e47c2 (osmo-ttcn3-hacks) Change-Id: I925a041936c6163483d70fe6d158af368ec8c444 --- M src/osmo-bsc/smscb.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/19632/1 diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 436826a..cb68578 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -664,6 +664,10 @@ llist_for_each_entry_safe(smscb, smscb2, &chan_state->messages, list) bts_smscb_del(smscb, chan_state, "RESET"); + osmo_timer_del(&bts->etws_timer); + + /* Make sure that broadcast is disabled */ + rsl_etws_pn_command(bts, RSL_CHAN_PCH_AGCH, NULL, 0); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I925a041936c6163483d70fe6d158af368ec8c444 Gerrit-Change-Number: 19632 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200813/6f95f49a/attachment.htm>