This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19627 ) Change subject: gscon timeout: use proper cause code for lchan release ...................................................................... gscon timeout: use proper cause code for lchan release Since we verify the cause code of the RSL channel release in ttcn3-bsc-tests, BSC_Tests.TC_chan_act_ack_est_ind_noreply shows an invalid release cause code of 127. Fix that. On gscon timeout, don't send the unrelated RSL code RSL_ERR_INTERWORKING, but a proper RR cause code. GSM48_RR_CAUSE_ABNORMAL_TIMER is defined as the proper cause for an expired timer (3GPP TS 44.018 10.5.2.31). Should fix this error in BSC_Tests.TC_chan_act_ack_est_ind_noreply: BSC_Tests.ttcn:1590 Dynamic test case error: Assigning invalid numeric value 127 to a variable of enumerated type @GSM_RR_Types.RR_Cause. Change-Id: Ic2e4b692e78f7b134fe57d1077a08adb48398e06 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index e3976eb..6a35c75 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -866,7 +866,7 @@ switch (fi->T) { case 993210: - gscon_release_lchan(conn, conn->lchan, true, true, RSL_ERR_INTERWORKING); + gscon_release_lchan(conn, conn->lchan, true, true, GSM48_RR_CAUSE_ABNORMAL_TIMER); /* MSC has not responded/confirmed connection with CC, this * could indicate a bad SCCP connection. We now inform the the -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic2e4b692e78f7b134fe57d1077a08adb48398e06 Gerrit-Change-Number: 19627 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200813/69505f5a/attachment.htm>