Change in osmo-ttcn3-hacks[master]: Add parsing and checking of StatsD metrics

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581 )

Change subject: Add parsing and checking of StatsD metrics
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581/1/library/StatsD_Checker.ttcn 
File library/StatsD_Checker.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581/1/library/StatsD_Checker.ttcn@48 
PS1, Line 48: record of
could probably be a 'set of', as 'record of' means ordering is strict/required? not critical.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581/1/library/StatsD_Checker.ttcn@91 
PS1, Line 91:     var StatsD_ConnHdlr vc_conn;
            :     
whitespace?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581/1/library/StatsD_Checker.ttcn@99 
PS1, Line 99:     map(self:STATS, system:STATS);
            :     S
whitespace?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581/1/library/StatsD_Types.ttcn 
File library/StatsD_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581/1/library/StatsD_Types.ttcn@17 
PS1, Line 17:   va
ws



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19581
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icd1317b5f192d98e6cdc6635788d450501992bf1
Gerrit-Change-Number: 19581
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 12 Aug 2020 18:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/f994c720/attachment.htm>