This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19576 ) Change subject: vty/command: introduce CMD_ATTR_REQ_RESTART attribute ...................................................................... Patch Set 1: > Patch Set 1: Code-Review-1 > > I think this is too simplistic. Restart of what? Restart of the program that implements the vty (e.g. OsmoBSC)? Restart of the BTS whose attributes we configured inside the BSC? Restart of a given link/connection? > > I think we don't need one global flag but we need the ability to have multiple flags that specify when a particular command becomes active. Their details will depend on the individual applications. Thanks for your input, and especially for the examples! I actually implemented what you described first, and then found myself asking how many potential variations of "when it applies" would we need. Somehow I decided that this would be a redundant complexity, and then took a step back to the approach proposed by Eric. Fortunately, I still have the initial implementation in stash. I'll finish and submit it then. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie4ae73936ef08755f7bf0d1095d4d649adf498ae Gerrit-Change-Number: 19576 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 12 Aug 2020 13:47:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/97557c17/attachment.htm>