Change in osmo-ttcn3-hacks[master]: fixup for "fix mscpool cleanup (fixes LCLS tests)"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Aug 12 01:06:21 UTC 2020


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19567 )


Change subject: fixup for "fix mscpool cleanup (fixes LCLS tests)"
......................................................................

fixup for "fix mscpool cleanup (fixes LCLS tests)"

For the VTY "Unknown Command" code path, we must actually call 'repeat', to
avoid racey VTY behavior from cruft stuck in the VTY pipe.

The missing 'repeat' caused massive random fallout in the 'latest' builds,
which often hits the 'Unknown Command' code path; fixed by this patch.

Change-Id: Ibd5adb359b3fb302e2c70700d911878aef605ff3
---
M library/Osmocom_VTY_Functions.ttcn
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/19567/1

diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn
index 4cf37c4..cb3434e 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -71,6 +71,8 @@
 					testcase.stop(fail, "VTY: Unknown Command");
 				} else {
 					log("VTY: Unknown Command (ignored)");
+					buf := buf & rx;
+					repeat;
 				}
 				};
 			[] pt.receive(charstring:?) -> value rx { buf := buf & rx; repeat };

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19567
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibd5adb359b3fb302e2c70700d911878aef605ff3
Gerrit-Change-Number: 19567
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200812/e7c3f0e7/attachment.htm>


More information about the gerrit-log mailing list