Change in osmo-bsc[master]: hodec2: do not keep candidates with zero requirements met

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Aug 10 20:09:00 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19559 )

Change subject: hodec2: do not keep candidates with zero requirements met
......................................................................

hodec2: do not keep candidates with zero requirements met

When check_requirements() returns zero, do not keep such an entry in the
candidates list at all. This removes logging confusion, where some "candidates"
are still listed even though not meeting any handover requirements.

Change-Id: I12e48292d5731cb601165c870b9570003bc488ec
---
M src/osmo-bsc/handover_decision_2.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c
index 26a8840..3191957 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -861,6 +861,10 @@
 	};
 
 	debug_candidate(&c, 0, tchf_count, tchh_count);
+
+	if (!c.requirements)
+		return;
+
 	clist[*candidates] = c;
 	(*candidates)++;
 }
@@ -966,6 +970,9 @@
 
 	debug_candidate(&c, av_rxlev, tchf_count, tchh_count);
 
+	if (!c.requirements)
+		return;
+
 	clist[*candidates] = c;
 	(*candidates)++;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19559
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I12e48292d5731cb601165c870b9570003bc488ec
Gerrit-Change-Number: 19559
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200810/c3d0e588/attachment.htm>


More information about the gerrit-log mailing list