This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19520 ) Change subject: oml: fix ARFCN range check in oml_rx_set_bts_attr() ...................................................................... oml: fix ARFCN range check in oml_rx_set_bts_attr() Change-Id: I52c15de3c59cd654207599ae410a4c1fed48ee58 --- M src/common/oml.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/oml.c b/src/common/oml.c index 34d1a5c..78d9c65 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -552,7 +552,7 @@ /* Test for globally unsupported stuff here */ if (TLVP_PRES_LEN(&tp, NM_ATT_BCCH_ARFCN, 2)) { uint16_t arfcn = ntohs(tlvp_val16_unal(&tp, NM_ATT_BCCH_ARFCN)); - if (arfcn > 1024) { + if (arfcn >= 1024) { /* 0 .. 1023 (1024 channels total) */ oml_tx_failure_event_rep(&bts->mo, NM_SEVER_MAJOR, OSMO_EVT_WARN_SW_WARN, "Given ARFCN %u is not supported", arfcn); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I52c15de3c59cd654207599ae410a4c1fed48ee58 Gerrit-Change-Number: 19520 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200804/c8e8ebcf/attachment.htm>