This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 ) Change subject: bsc: test RR Channel Release EARFCNs ...................................................................... Patch Set 3: > [...] but I don't like that instead of introducing a separate test case for (RR) Channel Release EARFCNs, you're integrating more checks into the existing tests. I see it as a test that has N EARFCNs configured and checks that these show up where they should: during init and during chan rel If we made these separate tests, we would blow up the number of tests: duplicate the 12 TC_si2quater_N_earfcns(), creating 12 more lines in the test results, 12 more tcpdumps taken, and so on. For what gain? The TC_si2quater_* would configure the EARFCNs and initialize the BTS links; and the 12 new rr_chan_rel tests would literally do the same, and then after that start a DCHAN and release. They simply and logically follow from the si2quater tests. Of course the test names then are slightly inaccurate, I intended to submit a renaming patch and discuss there whether we'd rather keep test names unchanging to not (temporarily) clutter test results summary in jenkins. > I suggest to make f_expect_chan_rel() return the received Channel Release message (instead of overloading it with even more functionality) hmm, the mode and style of that function seems to be to pass things that it should expect during channel release. If I return the CSFB cells instead, then what about the other expect_* arguments, should I return those as well? What about future additions of expected items, return those? Seems to me that passing an expected cell list for CSFB is the best match here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I882c5e1f70bcc4833fc837a95c900ce291919cc5 Gerrit-Change-Number: 19216 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2020 22:50:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200803/ca4d4464/attachment.htm>