Change in osmo-bts[master]: oml: fix ARFCN range check in oml_rx_set_radio_attr()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Aug 3 22:20:39 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/19519 )


Change subject: oml: fix ARFCN range check in oml_rx_set_radio_attr()
......................................................................

oml: fix ARFCN range check in oml_rx_set_radio_attr()

Change-Id: I11c8203dfe26175632974e5c6859eeaea962e878
---
M src/common/oml.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/19/19519/1

diff --git a/src/common/oml.c b/src/common/oml.c
index 39304f1..34d1a5c 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -775,7 +775,7 @@
 		memcpy(&_value, value, 2);
 		arfcn = ntohs(_value);
 		value += 2;
-		if (arfcn > 1024) {
+		if (arfcn >= 1024) { /* 0 .. 1023 (1024 channels total) */
 			oml_tx_failure_event_rep(&trx->bts->mo, NM_SEVER_MAJOR, OSMO_EVT_WARN_SW_WARN,
 						 "Given ARFCN %u is unsupported", arfcn);
 			LOGPFOH(DOML, LOGL_NOTICE, foh, "Given ARFCN %u is unsupported.\n", arfcn);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19519
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I11c8203dfe26175632974e5c6859eeaea962e878
Gerrit-Change-Number: 19519
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200803/e3b0382d/attachment.htm>


More information about the gerrit-log mailing list