Change in osmo-pcu[master]: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Apr 30 15:11:57 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17983 )

Change subject: pdch: Avoid sending GSMTAP_CHANNEL_UNKOWN for rejected UL EGPRS data block
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/17983/1//COMMIT_MSG@10 
PS1, Line 10: otherwise the generic
            : UNKNOWN gsmtap message will be sent.
> Well a lot of stuff shouldn't be done how it is in osmo-pcu right now, but it does it this way. […]
I am not asking you to do complete refactoring. Just make it not depend on the returned value (in a separate change), so there will be no need to change return code in this patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17983
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I853679ce8907d46fcb84ae4127335c10623f09c9
Gerrit-Change-Number: 17983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 30 Apr 2020 15:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200430/5ae65a32/attachment.htm>


More information about the gerrit-log mailing list