This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/17972 ) Change subject: src/input/ipaccess.c: set TCP_NODELAY ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c@314 PS1, Line 314: FIXME: just call update_fd_settings() here instead? > Can somebody more familiar with libosmo-abis advise me, if it would be better to call update_fd_sett […] Why is the setsockopt call needed here anyway? I don't see any new socket being created, only an osmo_fd wrapper for an already existing socket. I think we need to drop this call or move it near to where the socket is created if required. https://gerrit.osmocom.org/c/libosmo-abis/+/17972/1/src/input/ipaccess.c@600 PS1, Line 600: ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof(val)); update_fd_settings() is called to set line specific params to an already existing socket (I have my doubts current use and places wher eit is used makes sense, but anyway). In this case, we want to set TCP_NODEL on OML and RSL sockets ALWAYS. So simply move the call nexto where the socket fds are created. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/17972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia3d4c41bf0659e682f0b7ae5f3d58ed0f28edb58 Gerrit-Change-Number: 17972 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 29 Apr 2020 11:26:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200429/2fb27c3c/attachment.htm>