Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where needed

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17957 )

Change subject: library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where needed
......................................................................

library/GSM_RR_Types.ttcn: use 'CSN.1 L/H' attribute where needed

Thanks to Harald, TITAN's RAW codec now supports the L/H syntax.

Change-Id: I279901aeffd09de071d274944cd0f1a93d711f85
---
M library/GSM_RR_Types.ttcn
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 4dc0894..6e359ab 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -405,11 +405,11 @@
 */
 	};
 	type record SecondPartAssign {
-		BIT1		r99, /* H / L */
+		BIT1		r99, /* L / H */
 		BIT1		presence optional,
 		BIT5		ext_ra optional
 	} with {
-		/* TODO: use 'CSN.1 L/H' attribute here */
+		variant (r99) "CSN.1 L/H"
 		variant (presence) "PRESENCE(r99 = '1'B)" /* H */
 		variant (ext_ra) "PRESENCE(presence = '1'B)"
 	};
@@ -510,7 +510,9 @@
 	};
 	type record IaRestOctLL {
 		BIT1		compressed_irat_ho_info_ind
-	} with { variant "" };
+	} with {
+		variant (compressed_irat_ho_info_ind) "CSN.1 L/H"
+	};
 
 
 	type record of AccessTechnologiesRequest
@@ -650,6 +652,7 @@
 		IaRestOctHL	hl optional,
 		IaRestOctHH	hh optional
 	} with {
+		variant (presence) "CSN.1 L/H"
 		variant (ll) "PRESENCE(presence = '00'B)"
 		variant (lh) "PRESENCE(presence = '01'B)"
 		variant (hl) "PRESENCE(presence = '10'B)"
@@ -962,9 +965,7 @@
 				rest_octets := {
 					presence := '00'B, /* LL */
 					ll := {
-						/* Compressed INTER RAT HO INFO: shall not be used (L)
-						 * TODO: use variant "CSN.1 L/H" to avoid confusion. */
-						compressed_irat_ho_info_ind := '1'B
+						compressed_irat_ho_info_ind := '0'B /* L */
 					},
 					lh := omit, hl := omit, hh := omit
 				}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17957
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I279901aeffd09de071d274944cd0f1a93d711f85
Gerrit-Change-Number: 17957
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200429/0fdc1db8/attachment.htm>